closes #1072

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GottZ, WangMengabc
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

@meain hey there. can you please take a look at this, as @zwpaper seems to be on vacation off github for a month by now?

sorry for the delay, some personal issues have trapped me recently. I will look into PRs in following days

sorry for the delay, some personal issues have trapped me recently.

welcome back!

the change lgtm, but we may have some issues on tests, I am working on it, and will merge after I fix the tests

I'm at FrOSCon right now, lsd just got presented at a talk where I just had to mention this bug.

Hi @GottZ, thanks so much for provide the info about the talk, it was excited to know about people using lsd.

as for the bug, I beleive this PR has fix it and it should be good to go now, can you hekp checking the lsd from https://github.com/WangMengabc/lsd/tree/master, or I can build a binary for you if needed.

as for the bug, I beleive this PR has fix it and it should be good to go now, can you hekp checking the lsd from https://github.com/WangMengabc/lsd/tree/master, or I can build a binary for you if needed.

it's flawless. thanks!

thanks for the help, let's create a new release for this